Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to reflect new JuliaGeometry ownership #117

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Conversation

JoshuaLampert
Copy link
Member

After moving the repo to the JuliaGeometry org, the link for the documentation should be adjusted accordingly.
This is also a test PR to see whether CI, codecov and documentation deployment works.

@JoshuaLampert JoshuaLampert added the documentation Improvements or additions to documentation label Oct 23, 2024
@JoshuaLampert
Copy link
Member Author

Deploying the preview of the documentation works and is also hosted at the correct URL, see https://juliageometry.github.io/MeshIntegrals.jl/previews/PR117/?pr=117.

@mikeingold mikeingold changed the title Update links to docs page Update links to reflect new JuliaGeometry ownership Oct 23, 2024
src/MeshIntegrals.jl Outdated Show resolved Hide resolved
@JoshuaLampert
Copy link
Member Author

JoshuaLampert commented Oct 23, 2024

Looking at https://coveralls.io/github/JuliaGeometry/MeshIntegrals.jl seems like coveralls successfully recognizes the move, but https://app.codecov.io/gh/JuliaGeometry/MeshIntegrals.jl seems like codecov didn't. That something with codecov is still not working is also reflecting by the missing comment from the codecov bot in the PR. This indicates that it is still using the old url. But to investigate further we would need to look into the settings of the repo and check the CODECOV_TOKEN (maybe it changed after the move and needs to be updated with the new one?), however this is currently pending #115 (comment)

@JoshuaLampert
Copy link
Member Author

We also need to remember to update the link to the docs in the about section of the repo, but I guess you can also not edit this one @mikeingold, right?

@mikeingold
Copy link
Collaborator

We also need to remember to update the link to the docs in the about section of the repo, but I guess you can also not edit this one @mikeingold, right?

Correct. That’s actually what made me realize I had lost owner rights, since I now don’t have access to the settings icon that I would’ve used to modify that link.

@JoshuaLampert
Copy link
Member Author

We also need to remember to update the link to the docs in the about section of the repo, but I guess you can also not edit this one @mikeingold, right?

Correct. That’s actually what made me realize I had lost owner rights, since I now don’t have access to the settings icon that I would’ve used to modify that link.

Ok, let's wait for Julios response.

@juliohm
Copy link
Member

juliohm commented Oct 23, 2024

@JoshuaLampert @mikeingold you should both have admin rights in MeshIntegrals.jl now. Please let me know if it is not the case.

@mikeingold
Copy link
Collaborator

When I pull up my CodeCov profile I can still see the repo as if it's mikeingold/MeshIntegrals.jl. I don't see any options to update the source/url of the repo and the last commit it recognizes was 2 days ago, so it seems to have gotten disconnected.

Once we get owner rights set up, it looks like we can just use this link to set it up again from scratch with a new token.

@mikeingold
Copy link
Collaborator

We also need to remember to update the link to the docs in the about section of the repo

Done.

@mikeingold
Copy link
Collaborator

CodeCov token updated.

@JoshuaLampert
Copy link
Member Author

I reran CI. Let's see what happens.

Copy link

codecov bot commented Oct 23, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@JoshuaLampert
Copy link
Member Author

JoshuaLampert commented Oct 23, 2024

Looks like we are all set👍

@mikeingold mikeingold merged commit 93a9b1d into main Oct 23, 2024
4 checks passed
@mikeingold mikeingold deleted the docs-link branch October 23, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants